From e5fddeb4754fcc8de78eaf8853f2cf1925a6d242 Mon Sep 17 00:00:00 2001 From: Ilya Zhuravlev Date: Sat, 27 Mar 2021 05:51:29 -0400 Subject: [PATCH] warn user if example keyboard UID is used --- src/main/python/main_window.py | 7 ++++++- src/main/python/util.py | 8 ++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/main/python/main_window.py b/src/main/python/main_window.py index cfd9220..387aff0 100644 --- a/src/main/python/main_window.py +++ b/src/main/python/main_window.py @@ -14,7 +14,7 @@ from keymaps import KEYMAPS from layout_editor import LayoutEditor from macro_recorder import MacroRecorder from unlocker import Unlocker -from util import tr, find_vial_devices +from util import tr, find_vial_devices, EXAMPLE_KEYBOARDS from vial_device import VialKeyboard import themes @@ -216,6 +216,11 @@ class MainWindow(QMainWindow): else: self.current_device.open(None) + if isinstance(self.current_device, VialKeyboard) \ + and self.current_device.keyboard.keyboard_id in EXAMPLE_KEYBOARDS: + QMessageBox.warning(self, "", "An example keyboard UID was detected.\n" + "Please change your keyboard UID to be unique before you ship!") + self.rebuild() self.refresh_tabs() diff --git a/src/main/python/util.py b/src/main/python/util.py index a89e5f7..1c020ae 100644 --- a/src/main/python/util.py +++ b/src/main/python/util.py @@ -19,6 +19,14 @@ VIBL_SERIAL_NUMBER_MAGIC = "vibl:d4f8159c" MSG_LEN = 32 +# these should match what we have in vial-qmk/keyboards/vial_example +# so that people don't accidentally reuse a sample keyboard UID +EXAMPLE_KEYBOARDS = [ + 0xD4A36200603E3007, # vial_stm32f103_vibl + 0x32F62BC2EEF2237B, # vial_atmega32u4 + 0x38CEA320F23046A5, # vial_stm32f072 +] + def hid_send(dev, msg, retries=1): if len(msg) > MSG_LEN: