From 1751cce29930d431693c38cc59bcb14bf88994a3 Mon Sep 17 00:00:00 2001
From: Kyle Brown <kdb424@gmail.com>
Date: Fri, 21 Jun 2019 16:41:58 -0700
Subject: [PATCH] code cleanup to pass lint and some for flake8

---
 kmk/firmware.py | 22 +++++++++-------------
 1 file changed, 9 insertions(+), 13 deletions(-)

diff --git a/kmk/firmware.py b/kmk/firmware.py
index 1982156..389bde5 100644
--- a/kmk/firmware.py
+++ b/kmk/firmware.py
@@ -25,6 +25,7 @@ import kmk.util  # isort:skip
 import busio  # isort:skip
 
 import supervisor  # isort:skip
+from kmk import rgb  # isort:skip
 from kmk.consts import LeaderMode, UnicodeMode  # isort:skip
 from kmk.hid import USB_HID  # isort:skip
 from kmk.internal_state import InternalState  # isort:skip
@@ -42,9 +43,7 @@ import kmk.matrix  # isort:skip
 import kmk.hid  # isort:skip
 import kmk.internal_state  # isort:skip
 
-# GC runs automatically after CircuitPython imports. If we ever go back to
-# supporting MicroPython, we'll need a GC here (and probably after each
-# chunk of the above)
+# GC runs automatically after CircuitPython imports.
 
 # Thanks for sticking around. Now let's do real work, starting below
 
@@ -142,10 +141,10 @@ class Firmware:
             self._send_hid()
 
     def _handle_matrix_report(self, update=None):
-        '''
+        """
         Bulk processing of update code for each cycle
         :param update:
-        '''
+        """
         if update is not None:
             self._state.matrix_changed(
                 update[0],
@@ -166,7 +165,6 @@ class Firmware:
             update = bytearray(self.uart.read(3))
             # Built in debug mode switch
             if update == b'DEB':
-                # TODO Pretty up output
                 print(self.uart.readline())
                 return None
             return update
@@ -174,11 +172,11 @@ class Firmware:
         return None
 
     def _send_debug(self, message):
-        '''
+        """
         Prepends DEB and appends a newline to allow debug messages to
         be detected and handled differently than typical keypresses.
         :param message: Debug message
-        '''
+        """
         if self.uart is not None:
             self.uart.write('DEB')
             self.uart.write(message, '\n')
@@ -202,7 +200,6 @@ class Firmware:
         else:
             return busio.UART(tx=pin, rx=None, timeout=timeout)
 
-
     def go(self):
         assert self.keymap, 'must define a keymap with at least one row'
         assert self.row_pins, 'no GPIO pins defined for matrix rows'
@@ -216,7 +213,7 @@ class Firmware:
             self.col_pins = list(reversed(self.col_pins))
 
         if self.split_side == "Left":
-                self.split_master_left = self._master_half()
+            self.split_master_left = self._master_half()
         elif self.split_side == "Right":
             self.split_master_left = not self._master_half()
 
@@ -228,8 +225,8 @@ class Firmware:
                                   self.hue_step, self.sat_step, self.val_step,
                                   self.hue_default, self.sat_default, self.val_default,
                                   self.breathe_center, self.knight_effect_length,
-                                  self.val_limit, self.animation_mode, self.animation_speed
-            )
+                                  self.val_limit, self.animation_mode, self.animation_speed,
+                                  )
 
         self.matrix = MatrixScanner(
             cols=self.col_pins,
@@ -292,5 +289,4 @@ class Firmware:
             if self.pixels.animation_mode is not None:
                 self.pixels = self.pixels.animate()
 
-
             gc.collect()